Przejdź do treści
Biblioteka skilli
Programowanie · Przegląd i audyt

webapps-testing-review

/webapps-testing-review

Przegląda testy Web Apps w Chromium (jednostkowe, przeglądarkowe, interaktywne UI i integracyjne testy synchronizacji), sprawdzając m.in. oczekiwanie na zakończenie komend i przygotowanie FakeWebAppProvider.

Repozytorium
chromium ↗
Licencja
BSD-3-Clause
Ostatnia zmiana repozytorium
25.10.2026

Ocena i bezpieczeństwo

100/ 100Klasa: dobry
Format25 / 25
Frontmatter z nazwą i opisem, poprawna nazwa, opis do 1024 znaków, nazwa zgodna z folderem.
Odkrywalność25 / 25
Opis mówi, kiedy użyć skilla, ma sensowną długość i jest w 3. osobie.
Treść35 / 35
Co najmniej 150 słów i do 500 linii, nagłówki, listy kroków, przykłady albo kod.
Higiena15 / 15
Bez zaślepek typu TODO, bez ścieżek Windows, z licencją.
Ryzykobrak sygnałów w skanie
Pliki w paczce
1
Skrypty
0
Komentarze HTML
0
Adresy URL w SKILL.md
0
Przestarzałość

Brak sygnałów. Repozytorium zmienione 25.10.2026, bez odwołań do wycofanych modeli i API.

Licencja

BSD-3-Clause, otwarta.

Co robi i kiedy

Przegląda testy Web Apps w Chromium (jednostkowe, przeglądarkowe, interaktywne UI i integracyjne testy synchronizacji), sprawdzając m.in. oczekiwanie na zakończenie komend i przygotowanie FakeWebAppProvider.

Oryginalny opis (EN)

Reviews Web Apps tests: unit, browser, and interactive UI tests (*_unittest.cc, *_browsertest.cc, *_interactive_uitest.cc) in chrome/browser/web_applications/, chrome/browser/ui/web_applications/, and chrome/browser/ui/views/web_apps/, and the web apps sync integration tests in chrome/browser/sync/test/integration/web_apps/. It checks command completion waits, FakeWebAppProvider setup before provider start, FakeWebContentsManager page state, test install helpers, OS integration test overrides, and test assertions on command debug values. Use when a CL adds or changes these test files.

Jak działa

SKILL.md bez nagłówków drugiego poziomu · 101 linii, 666 słów

Podgląd SKILL.md
---
name: webapps-testing-review
description: >-
  Reviews Web Apps tests: unit, browser, and interactive UI tests
  (*_unittest.cc, *_browsertest.cc, *_interactive_uitest.cc) in
  chrome/browser/web_applications/, chrome/browser/ui/web_applications/, and
  chrome/browser/ui/views/web_apps/, and the web apps sync integration tests in
  chrome/browser/sync/test/integration/web_apps/. It checks command completion
  waits, FakeWebAppProvider setup before provider start, FakeWebContentsManager
  page state, test install helpers, OS integration test overrides, and test
  assertions on command debug values. Use when a CL adds or changes these test
  files.
---

### `WEBAPPS_AWAIT_COMMANDS_INSTEAD_OF_IDLE_OR_SLEEP`: Wait on command completion via `base::test::TestFuture` (or test observers) instead of `RunUntilIdle()` or sleeps

- **Severity**: WARNING
- **Why**: `RunUntilIdle()` and fixed timers do not wait for `WebAppCommand`s
  that are blocked on `PartitionedLockManager` locks or on a `WebContents` load,
  which is a primary source of flaky Web App tests.
- **Look for**: `base::RunLoop().RunUntilIdle()`,
  `task_environment()->RunUntilIdle()`, `base::PlatformThread::Sleep`, or
  fixed-delay `PostDelayedTask` used to wait for a web app command, install,
  update, uninstall, or launch to finish.
- **Fix**: Primarily pass `future.GetCallback()` from a
  `base::test::TestFuture<...>` directly to the command or `scheduler()` call
  (when it accepts a completion callback) and wait via `future.Wait()` /
  `future.Get()`. When no direct completion callback is available on the
  triggered flow, use `WebAppPageWaiter::WaitAndFlushCommands()`, a
  `WebAppTestInstallObserver` / `WebAppTestUninstallObserver` /
  `WebAppTestManifestUpdatedObserver`, or
  `provider().command_manager().AwaitAllCommandsCompleteForTesting()`.
- **Do not flag**: `RunUntilIdle()` used for non-`WebAppProvider` work (such as
  flushing a `MockCallback`), or `base::test::TestFuture` /
  `base::RunLoop::Run()` driven by an explicit completion callback.

### `WEBAPPS_USE_FAKE_PAGE_STATE_NOT_DATA_RETRIEVER`: Set page state through `FakeWebContentsManager`, not new `FakeDataRetriever` or `TestWebAppUrlLoader` uses

- **Severity**: WARNING
- **Why**: `FakeWebAppProvider` sends all `WebContents` access to
  `FakeWebContentsManager`. Fake page state then drives URL loads, manifests,
  and icons together. Custom data retrievers and URL loaders couple tests to
  internal call sequences and drift from real behavior. Tests can schedule
  commands through `provider().scheduler()`, or get a loader or retriever from
  `fake_web_contents_manager().CreateUrlLoader()` and `CreateDataRetriever()`.
- **Look for**: New uses of `TestWebAppUrlLoader`, `FakeDataRetriever`, or
  `MockDataRetriever` in unit tests, for example `SetManifest()` or
  `SetNextLoadUrlResult()` calls. Direct construction of a command or job with
  these fakes, or calls to `SetUrlLoaderForTesting()` or
  `SetDataRetrieverForTesting()`, instead of `provider().scheduler()` or
  `fake_web_contents_manager()`.
- **Do not flag**: Any use of `FakeWebContentsManager` (through
  `fake_web_contents_manager()`), also after provider start. Existing uses of
  `TestWebAppUrlLoader`, `FakeDataRetriever`, or `MockDataRetriever` that the CL
  does not change. The files that define these fakes or the `Set*ForTesting()`
  methods, for example `test/fake_data_retriever.cc`,
  `test/fake_web_contents_manager.cc`, and `jobs/install_placeholder_job.cc`.

### `WEBAPPS_INSTALL_TEST_APPS_WITH_TEST_UTILS`: Install test web apps with the test install helpers, not `ScopedRegistryUpdate::CreateApp()`

- **Severity**: WARNING
- **Why**: `WebAppRegistryUpdate::CreateApp()` writes a raw `WebApp` object into
  the registry. It skips install commands, locks, icon writes, OS integration,
  and install observers. `web_app_registry_update.h` and
  `test/web_app_test_utils.h` forbid `CreateApp()`, `test::CreateWebApp()`,
  `test::CreateWebAppFromSyncProto()`, and `test::CreateRandomWebApp()` for
  installs in tests.
- **Look for**: Calls to `WebAppRegistryUpdate::CreateApp()` (through
  `ScopedRegistryUpdate`, for example `sync_bridge_unsafe().BeginUpdate()`) or
  `test::CreateWebApp()`, `test::CreateWebAppFromSyncProto()`, or
  `test::CreateRandomWebApp()` that install an app in a unit test or a browser
  test.
- **Do not flag**: `test::InstallDummyWebApp()`, `test::InstallWebApp()`,
  `test::InstallWebAppWithoutOsIntegration()`, `InstallWebAppFromPage()`,
  `InstallWebAppFromPageGetBrowser()`, `InstallWebAppFromManifest()`,
  `test::InstallPwaForCurrentUrl()`, `IsolatedWebAppBuilder`, or a scheduler
  command. The registrar, sync bridge, database, proto utils, and `WebApp` unit
  tests (`web_app_registrar_unittest.cc`, `web_app_sync_bridge_unittest.cc`,
  `web_app_database*_unittest.cc`, `web_app_proto_utils_unittest.cc`, and
  `web_app_unittest.cc`). `UpdateApp()` or `DeleteApp()` calls through
  `ScopedRegistryUpdate` that change an app that the test installed before, for
  example in `single_client_web_apps_sync_generated_icon_fix_sync_test.cc`. The
  helper definitions in `test/web_app_test_utils.cc`.

### `WEBAPPS_ASSERT_OUTCOMES_NOT_COMMAND_DEBUG_VALUES`: Assert command results, app state, or histograms, not command debug values

- **Severity**: WARNING
- **Why**: Command debug values (`GetMutableDebugValue()`, the
  `WebAppCommandManager` log, and `ToDebugValue()` output) exist for
  chrome://web-app-internals and bug reports. Their keys and strings are not a
  contract, and authors change them without test updates. A test that reads them
  checks internal steps of the command, not its behavior. When a key changes,
  the test fails for no real reason, or a `nullptr` check makes it pass without
  a real check.
- **Look for**: New test code that reads
  `provider().command_manager().log().GetEntries()`,
  `command_manager().ToDebugValue()`, or a command's `GetDebugValue()`, and then
  checks dict keys (for example `FindBool("...")`, `FindString("...")`,
  `base::test::DictionaryHasValues`, `base::test::DictionaryHasValue` or
  `FindStringByDottedPath("!metadata.!name")`) to prove that a command did or
  skipped a step. New test helpers, such as `GetLastCommandDebugValue()`, that
  search the log for a command name.
- **Fix**: Assert the command result from a `base::test::TestFuture` (for
  example `webapps::InstallResultCode`), the registrar or OS integration state,
  or UMA through `base::HistogramTester` (for example `WebApp.Install.Result`
  and `WebApp.Install.Source.Failure`). If the result does not tell two cases
  apart, use or add a more specific result code.
- **Do not flag**: Tests of the debug output itself, for example
  `WebAppCommandManagerTest.ToDebugValue`, the `ToDebugValue` tests in `locks/`,
  the `WebApp` debug value test in `web_app_unittest.cc`, and
  `IwaCacheOneAppTest.GetDebugValue`. Debug values that a test only prints in a
  failure message (`<< debug_value`). Existing debug value reads that the CL
  does not change.

Wersje

W bazie nie ma innych skilli o nazwie webapps-testing-review.

Migawka bazy z 13.11.2026 · wersja paczki efbd947951b0 (skrót SHA-256 całej paczki)

Pobrania w ostatnich 30 dniach: 0 · ranking

Zgłoś problem z tym skillem: szkodliwa treść, błędny opis albo prośba autora o usunięcie.

Podobne skille

  • 100webapps-command-and-lock-review
    Przegląda zmiany w kodzie web_applications Chromium pod kątem kończenia WebAppCommand i niezmienników blokowania, niebezpiecznego dostępu do WebAppProvider, ponownej walidacji stanu StartWithLock i zakleszczeń.
  • 86webapps-layering-and-security-review
    Przegląda zmiany w kodzie Chromium Web Apps pod kątem walidacji origin w usługach Mojo przez RenderFrameHost i zgłaszania bad message.
  • 100testing-webapps
    Pisze skrypty Playwright w Pythonie do testowania lokalnej aplikacji webowej, zrzutów ekranu i logów przeglądarki.
  • 95memstack-development-webapp-testing
    Pisze testy przeglądarkowe end-to-end w Playwright, sprawdzające działanie interfejsu aplikacji webowej.
  • 95web-testing
    Automatyzuje testy w Playwright i Chrome DevTools: testy E2E i jednostkowe, zrzuty ekranu, podgląd sieci i konsoli oraz walidację ścieżek użytkownika.
  • 100testing
    Pisze i uruchamia testy aplikacji Frappe: jednostkowe, integracyjne i UI, oraz pomaga w debugowaniu porażek i konfiguracji CI.

Uwagi i zgłoszenia

Wiadomość trafi do Bartosza Sokolińskiego. Adres e-mail jest potrzebny tylko do odpowiedzi. Szczegóły w polityce prywatności.