land-stack-change
/land-stack-change
Zamienia wyniki badania w czyste, przeglądalne commity w stosie VirtIO GPU i sprawdza poprawkę względem dokumentacji API.
- Autor
- utmapp ↗
- Repozytorium
- utmapp-bot ↗
- Licencja
- Apache-2.0
- Ostatnia zmiana repozytorium
- 12.11.2026
Ocena i bezpieczeństwo
- Pliki w paczce
- 1
- Skrypty
- 0
- Komentarze HTML
- 0
- Adresy URL w SKILL.md
- 0
Brak sygnałów. Repozytorium zmienione 12.11.2026, bez odwołań do wycofanych modeli i API.
Apache-2.0, otwarta: można używać i zmieniać, z zachowaniem licencji i informacji o zmianach.
Co robi i kiedy
Zamienia wyniki badania w czyste, przeglądalne commity w stosie VirtIO GPU i sprawdza poprawkę względem dokumentacji API.
Argumenty
/land-stack-change [repo paths]
Oryginalny opis (EN)
Turn an investigation's working tree into clean, reviewable commits across the repos of the VirtIO GPU stack (guest driver, KMD, virglrenderer, backend shims, QEMU, UTM) — separate diagnostics from the fix, check it against the API documentation (MSDN for DirectX APIs and DDIs, the Vulkan spec), fix the related paths that share the bug, run /code-review at high effort before anything is published and validate again after it, split it into logical commits that each carry their own evidence, follow each repo's own attribution and message rules, and leave nothing pushed that was not asked for. Ev
Jak działa
- 1. Inventory
- 2. Take the diagnostics out
- 3. Split into logical commits
- 4. Review before publishing
- 5. Messages and attribution
- 6. History
- 7. Report
Podgląd SKILL.md
---
name: land-stack-change
description: Turn an investigation's working tree into clean, reviewable commits across the repos of the VirtIO GPU stack (guest driver, KMD, virglrenderer, backend shims, QEMU, UTM) — separate diagnostics from the fix, check it against the API documentation (MSDN for DirectX APIs and DDIs, the Vulkan spec), fix the related paths that share the bug, run /code-review at high effort before anything is published and validate again after it, split it into logical commits that each carry their own evidence, follow each repo's own attribution and message rules, and leave nothing pushed that was not asked for. Every skill that changes code in the UTM graphics stack lands it through here (db-triage, triage-gpu-issue, attribute-to-layer, repro-gpu-issue). Use when asked to "commit this", "clean up the branch", "prepare a PR", "squash", or "land the fix".
argument-hint: "[repo paths]"
---
# Land a change
Repos: `$ARGUMENTS` (default: every tree touched in this session)
## 1. Inventory
For every tree involved, `git status`, `git diff --stat`, and `git log
@{u}..` when there is an upstream. Investigations leave edits in several
trees; find all of them, including ones from earlier sessions. List the
files per tree and classify each hunk:
- **fix**: the change that solves the problem;
- **diagnostic**: logging, traces, counters, env knobs, asserts added to
investigate, timing probes;
- **unrelated**: formatting, drive-by edits, editor noise.
## 2. Take the diagnostics out
Diagnostics never go into commits. That includes knobs that turn behavior
on and off: features are always on, and a knob is a diagnostic.
Save them as patches so the next investigation can reapply them:
```sh
mkdir -p ~/.utmapp-bot/patches/<repo>
git diff -- <files or hunks> > ~/.utmapp-bot/patches/<repo>/<date>-<topic>.patch
```
Revert them in the tree (`git checkout -p` hunk by hunk). Then rebuild and
rerun the proof, to be sure the fix does not depend on a diagnostic.
## 3. Split into logical commits
- One commit per logical change. A commit must build and pass on its own.
- **Each commit proves its own effect.** Give it the probe verdict
(fail before, pass after), the benchmark delta, or the conformance-test
diff that shows *that commit's* improvement, measured on the commit in
sequence. A change in a bundle that shows no measurable effect is dropped,
not kept "just in case".
- Do not touch code you did not need to change. Match the surrounding style
and comment density. Comments say why the code is the way it is now, not
the history of the investigation.
- **No version or ABI bumps for contracts that have not shipped.** Edit the
unreleased version in place. A protocol or ABI change ships in lockstep
across its consumers (guest driver ↔ host protocol; virglrenderer ↔
backend shims). Rebuild them all, with no compatibility path for unshipped
versions.
## 4. Review before publishing
Every change to the UTM graphics stack goes through this before it is
pushed or published as a fix branch (db-triage's `fix-branch` included),
whichever skill made it.
1. **Check it against the documentation.** For anything that touches the
DirectX stack (a D3D/DXGI API or a WDDM/D3D DDI, user-mode or
kernel-mode), look up each function, structure and flag the change uses
or implements on Microsoft Learn (MSDN) online: the remarks, the
return values, and the notes on edge cases (zero sizes, NULL or optional
arguments, flags that change meaning together, which callbacks the
runtime allows from where). Those notes are often nowhere in the headers
and are the most useful part. For Vulkan, check the Vulkan specification:
the command's valid usage rules and the extension's text. Fix what the
change gets wrong against them.
2. **Variant analysis: fix the related paths too.** A bug in one function
is often in its siblings: the other API versions (D3D11 and D3D12),
the create and destroy halves, the shared and non-shared paths, the
other formats or resource kinds handled by the same code, and code that
was copied from it. Search for them and fix the ones that have the same
bug. A synthetic test of those paths (`/utmapp-bot:write-gpu-probe`) is
recommended, not required.
3. **`/code-review high`** on the change (the working tree, or the branch
against its base). High is the default effort; never max unless the
user asks. Weigh what it finds in this order: **performance, robustness,
correctness.** Fast code that handles 99% of cases and never crashes
beats covering the last 1% with a lot of extra code that can regress
other paths. Two things are never traded away: the code must not crash
(the guest, the host renderer, QEMU or UTM), and it must not open a
security hole (the guest is untrusted input to the host). Apply what is
worth it, and say in the report what you left and why.
4. **Validate again.** The review and the variant fixes changed the code:
rebuild, rerun the proof (probe fail before, pass after), the reporter's
path when there is one, and the validation the change already had
(`/utmapp-bot:validate-stack`, `/utmapp-bot:perf-regression`).
5. **Review again only if it changed a lot.** Significant changes from
steps 1 to 3 (new logic, other functions, another repository) go
through steps 3 and 4 once more; small ones (a check, a rename, a
comment) do not.
6. **Adjacent fixes are their own commits.** A related path fixed in step
2 is usually a separate logical change: commit it separately (step 3),
with its own evidence.
## 5. Messages and attribution
- Read the repo's own rules before writing: `CONTRIBUTING.md`, `AGENTS.md`,
`CLAUDE.md`, recent `git log`. Title format: e.g. `component: summary`.
Body: the problem, the cause and the fix, plus the evidence from step 3.
- **Attribution trailer:** use the one the repo asks for. Some repos
require `Assisted-by: AGENT:MODEL` and forbid `Co-Authored-By`; others use
`Co-Authored-By`. Never add session links.
- **Amending or fixing up an existing commit:** keep its trailers as they
are; do not add a new attribution to someone's existing commit.
- Commit messages and PR text describe the technical change. Leave out
business context the repo does not need.
- Write the message to a file and use `git commit -F <file>`; shell quoting
mangles multi-line messages.
## 6. History
- Linear history: rebase, never merge, onto the target branch.
`git rebase -i` is not available to the agent, so build the sequence with
`git commit --fixup` plus `GIT_SEQUENCE_EDITOR=: git rebase -i --autosquash`,
or by cherry-picking onto a fresh branch.
- **Do not push unless asked.** Then use `--force-with-lease`, never
`--force`.
- **Pull requests:** to utmapp/UTM only through UTM's own skills,
`.agents/skills/utm-review` then `.agents/skills/utm-submit` (in auto
mode, accept every change the review recommends, and validate again),
never by hand. To any other repository, never: fix branches only. Report every commit hash and which ones are unpushed.
## 7. Report
Per repo: branch, the new commits (hash and title), the evidence each one
carries, the documentation checked, the related paths found (fixed or
not, and why), what `/code-review` found and what was applied, the
validation after it, patches saved for diagnostics, and anything left
uncommitted on purpose.
Wersje
W bazie nie ma innych skilli o nazwie land-stack-change.
Migawka bazy z 13.11.2026 · wersja paczki 55835bf98dd1 (skrót SHA-256 całej paczki)
Pobrania w ostatnich 30 dniach: 0 · ranking
Zgłoś problem z tym skillem: szkodliwa treść, błędny opis albo prośba autora o usunięcie.
Podobne skille
- 100run-gpu-test-vm
Uruchamia i obserwuje stos sterownika VirtIO GPU w jednorazowej maszynie testowej UTM: instaluje sterownik, sprawdza Direct3D i zbiera zrzuty oraz logi. - 100attribute-to-layer
Ustala, która warstwa stosu VirtIO GPU odpowiada za błąd, testując backendy, wersje D3DMetal i zachowanie Wine. - 100qemu-for-kernel-development
Uruchamia własne jądra w QEMU z rootfs z Buildroota lub Yocto, testuje urządzenia virtio i moduły sterowników, także przez NFS root. - 90committing
Tworzy czyste commity git w stylu projektu, dzieli zmiany na commity i pomaga przygotować pull request. - 100pr-workflow
Zamienia gotową pracę w czyste commity i pull request podzielony na logiczne zmiany, a potem pilnuje go w CI. - 100commit-work
Tworzy czyste commity: sprawdza zmiany, dzieli je na logiczne części i uruchamia bramkę potoku przed każdym commitem.