Skip to content
Skills Library
Programming · Review & audit

code-smells

/code-smells

Code smells that block a change: Fowler's catalogue under the repo's own standards. Use whenever you write, fix or refactor code, or rule on a code change, before you call it done.

Repository
maestro ↗
Licence
MIT
Last repository change
13.11.2026

Assessment and security

82/ 100Class: good
Format25 / 25
Frontmatter with name and description, valid name, description up to 1,024 characters, name matching the folder.
Discoverability25 / 25
Description explains when to use the skill, has a reasonable length and uses third person.
Content17 / 35
At least 150 words and at most 500 lines, headings, step lists, examples or code.
Hygiene15 / 15
No placeholders such as TODO, no Windows paths, with a licence.
Riskno signals detected in the scan
Files in this package
1
Scripts
0
HTML comments
0
URLs in SKILL.md
0
Deprecation

No signals detected. Repository changed on 13.11.2026, without references to retired models or APIs.

Licence

MIT, open: use and modify while retaining author attribution.

What it does and when to use it

Code smells that block a change: Fowler's catalogue under the repo's own standards. Use whenever you write, fix or refactor code, or rule on a code change, before you call it done.

Triggers from the description

s catalogue under the repo
Original author description

Code smells that block a change: Fowler's catalogue under the repo's own standards. Use whenever you write, fix or refactor code, or rule on a code change, before you call it done.

How it works

SKILL.md has no level-two headings · 36 lines, 394 words

SKILL.md preview
---
name: code-smells
description:
  "Code smells that block a change: Fowler's catalogue under the repo's own standards. Use whenever you write, fix or
  refactor code, or rule on a code change, before you call it done."
---

The **smell baseline** below is a fixed set of Fowler code smells (_Refactoring_, ch.3) that applies even when a repo
documents nothing. Two rules bind it:

- **The repo overrides.** A documented repo standard always wins; where it endorses something the baseline would flag,
  suppress the smell.
- **In scope blocks.** A smell in code the change adds, or in a function it touches, is a defect to fix and blocks;
  elsewhere it never blocks. Each smell is a heuristic: confirm it in the code, and skip anything tooling already
  enforces.

Each smell reads _what it is_ → _how to fix_; match it against the change:

- **Mysterious Name**: a function, variable, or type whose name doesn't reveal what it does or holds. → rename it; if no
  honest name comes, the design's murky.
- **Duplicated Code**: the same logic shape appears in more than one hunk or file in the change. → extract the shared
  shape, call it from both.
- **Feature Envy**: a method that reaches into another object's data more than its own. → move the method onto the data
  it envies.
- **Data Clumps**: the same few fields or params keep travelling together (a type wanting to be born). → bundle them
  into one type, pass that.
- **Primitive Obsession**: a primitive or string standing in for a domain concept that deserves its own type. → give the
  concept its own small type.
- **Repeated Switches**: the same `switch`/`if`-cascade on the same type recurs across the change. → replace with
  polymorphism, or one map both sites share.
- **Shotgun Surgery**: one logical change forces scattered edits across many files in the change. → gather what changes
  together into one module.
- **Divergent Change**: one file or module is edited for several unrelated reasons. → split so each module changes for
  one reason.
- **Speculative Generality**: abstraction, parameters, or hooks added for needs the spec doesn't have. → delete it;
  inline back until a real need shows.
- **Message Chains**: long `a.b().c().d()` navigation the caller shouldn't depend on. → hide the walk behind one method
  on the first object.
- **Middle Man**: a class or function that mostly just delegates onward. → cut it, call the real target direct.
- **Refused Bequest**: a subclass or implementer that ignores or overrides most of what it inherits. → drop the
  inheritance, use composition.

Versions

The database has no other skills named code-smells.

Database snapshot: 13.11.2026 · package version d72bca88e75d (SHA-256 digest of the entire package)

Downloads in the last 30 days: 0 · ranking

Report a problem with this skill: harmful content, incorrect descriptions or an author’s removal request.

Similar skills

  • 100coding-standards
    Detects code smells, anti-patterns, and readability issues. Use when implementing features, reviewing code, or refactoring.
  • 87fowler
    A refactoring advisor grounded in Martin Fowler's "Refactoring: Improving the Design of Existing Code" (2nd edition). Diagnoses code smells, guides or applies refactorings using Fowler's step-by-step mechanics (small behavior-preserving steps with tests between them), and…
  • 100refactoring
    Refactoring catalogs of Martin Fowler (Refactoring, 2nd ed.) and Joshua Kerievsky (Refactoring to Patterns): 29 code smells, 66 refactorings and 27 refactorings to patterns (Strategy, State, Command, Observer, Composite, Factory, Template Method...), each with mechanics, a C#…
  • 95refactor
    Expert code refactoring based on Martin Fowler's catalog — improve maintainability without changing behavior. Covers code smells, composing methods, moving features, organizing data, simplifying conditionals, method calls, and generalization. Triggers on: refactor, 重构, clean up,…
  • 100refactor
    Analyze complexity and smells, draft a safe refactor plan, and execute step-by-step with tests. Use when refactoring code or invoking /refactor.
  • 90clean-coder
    Enforces Clean Code standards, identifies code smells, and ensures SOLID principles. Use when: clean code, code smell, SOLID, refactor, quality check.

Feedback and reports

Your message goes to Bartosz Sokoliński. An email address is needed only for a reply. See the privacy policy.