Skip to content
Skills Library
Programming · Review & audit

code-quality

/code-quality

The review checklist for Java and Spring Boot changes - what to look for (correctness, API semantics, security, performance, distributed-system pitfalls, code smells) and how serious each finding is. Use when reviewing a diff, branch, or pull request, or when asked to check, clean up, or refactor code. The code-reviewer agent runs the review; this skill supplies the checks.

Licence
MIT
Last repository change
09.11.2026

Assessment and security

100/ 100Class: good
Format25 / 25
Frontmatter with name and description, valid name, description up to 1,024 characters, name matching the folder.
Discoverability25 / 25
Description explains when to use the skill, has a reasonable length and uses third person.
Content35 / 35
At least 150 words and at most 500 lines, headings, step lists, examples or code.
Hygiene15 / 15
No placeholders such as TODO, no Windows paths, with a licence.
Riskno signals detected in the scan
Files in this package
8
Scripts
0
HTML comments
0
URLs in SKILL.md
0
Deprecation

No signals detected. Repository changed on 09.11.2026, without references to retired models or APIs.

Licence

MIT, open: use and modify while retaining author attribution.

What it does and when to use it

The review checklist for Java and Spring Boot changes - what to look for (correctness, API semantics, security, performance, distributed-system pitfalls, code smells) and how serious each finding is. Use when reviewing a diff, branch, or pull request, or when asked to check, clean up, or refactor code. The code-reviewer agent runs the review; this skill supplies the checks.

Original author description

The review checklist for Java and Spring Boot changes - what to look for (correctness, API semantics, security, performance, distributed-system pitfalls, code smells) and how serious each finding is. Use when reviewing a diff, branch, or pull request, or when asked to check, clean up, or refactor code. The code-reviewer agent runs the review; this skill supplies the checks.

How it works

  1. When It Applies
  2. Which Files to Read
  3. How Serious Is It?
  4. Out of Scope
  5. Quick Scan
Original SKILL.md headings · 63 lines, 538 words
SKILL.md preview
---
name: code-quality
description: The review checklist for Java and Spring Boot changes - what to look for (correctness, API semantics, security, performance, distributed-system pitfalls, code smells) and how serious each finding is. Use when reviewing a diff, branch, or pull request, or when asked to check, clean up, or refactor code. The code-reviewer agent runs the review; this skill supplies the checks.
---

# Code Quality Checklist

What a reviewer looks for in a Java / Spring Boot change and how to rate it. The `code-reviewer` agent owns the process and the report; the rules themselves live in `conventions`, `spring-boot`, `messaging-patterns`, and `architecture`. The files here only say **how to spot** a problem and point to the rule, so each rule is written down once.

## When It Applies

- Reviewing a diff, branch, or pull request before it is merged
- "Check this code", "clean this up", "is this endpoint right?"
- Before releasing a change to an API or an event

## Which Files to Read

Read only what matches the change.

| The change touches | Read |
|--------------------|------|
| Any Java | `references/correctness.md` and `references/spring-conventions.md` |
| Controllers, DTOs, status codes, error responses | `references/api-contract.md` |
| Input handling, authentication, permissions, configuration, secrets | `references/security.md` |
| Repositories, queries, loops over entities | `references/performance.md` |
| Kafka listeners or templates, outbox/inbox, events, HTTP clients, retries, caches, scheduled jobs | `references/distributed.md` |
| Entities, SQL migrations, `spring.jpa.*` | `conventions` → Database Schema with Flyway, and `spring-boot` → `references/data.md` |
| Anything with real logic | `references/smells.md` |
| A RAG service (Spring AI, vector store, embeddings, ingestion, prompts) | `rag-patterns` (`references/pipeline.md`, `security.md`) and the `rag-evaluator` agent |
| Any new or changed service, listener, client, relay, or exception handler | `spring-boot` → `references/logging.md` ("Review Signals") |

Where the underlying rules live:

| Topic | Source |
|-------|--------|
| House rules (Lombok first, records, Problem Details, Flyway, testing) | `conventions` |
| Fetching, N+1, transactions, locking, migrations | `spring-boot` → `references/data.md` |
| Test quality and Testcontainers | `spring-boot` → `references/testing.md` |
| Outbox, consumers, event contracts, dead-letter topics | `messaging-patterns` |
| Service boundaries, projections, sagas | `architecture` |

## How Serious Is It?

| Level | Meaning | Examples |
|-------|---------|----------|
| **Critical** | Must be fixed before merging | security hole, data loss or corruption, events for changes that never happened, crash on a normal path |
| **Important** | Should be fixed | wrong behaviour in an edge case, missing test for new behaviour, N+1 on a hot path, missing timeout |
| **Smell** | Worth a look | naming, length, duplication; always worded as "possible …" |
| **Good** | Worth repeating | a pattern others should copy |

## Out of Scope

- Anything a formatter or linter already enforces (whitespace, import order, brace style)
- Rewrites that only reflect taste and fix nothing concrete
- Choices the repository made on purpose: if `CLAUDE.md`, `conventions`, or an ADR says otherwise, the repository wins

## Quick Scan

| Area | Look for |
|------|----------|
| Nulls | `Optional.get()`, returned `null`, long getter chains |
| Exceptions | empty `catch`, catching `Exception`, a new exception without its cause |
| Transactions | multi-step writes outside `@Transactional`, calling a `@Transactional` method on `this` |
| API | state change on `GET`, wrong status code, contract change without a version bump |
| Data | loop that triggers a query per row, unbounded `findAll()`, unescaped `LIKE` |
| Distributed | Kafka send inside a business transaction, consumer without dedup, shared dead-letter topic, HTTP call without timeout |
Files in this package (8)
  • SKILL.md 4 KB
  • references/api-contract.md 1 KB
  • references/correctness.md 2 KB
  • references/distributed.md 3 KB
  • references/performance.md 1 KB
  • references/security.md 1 KB
  • references/smells.md 1 KB
  • references/spring-conventions.md 2 KB

Versions

RepositoryScoreLicence
This page · jasbir125/claude-ai-spring-boot100MIT
nasrulhazim/claude100MIT
piomin/claude-ai-spring-boot100Apache-2.0
joris887/exosuit100MIT
BlackBeltTechnology/pi-agent-dashboard100MIT
wrongstack/wrongstack100MIT
microsoft/winappcli100MIT
ingvarch/skills100MIT
oborchers/fractional-cto100MIT

Database snapshot: 13.11.2026 · package version dc04bfea0e09 (SHA-256 digest of the entire package)

Downloads in the last 30 days: 0 · ranking

Report a problem with this skill: harmful content, incorrect descriptions or an author’s removal request.

Similar skills

  • 100code-review-checklist
    Review checklist - correctness, security, performance, quality, tests, AI code. Use when reviewing code or a PR.
  • 100review-checklist
    Structured code review for this stack: a checklist covering correctness, security (OWASP Top 10, authorization, input validation, secrets), Spring Boot pitfalls (N+1, transaction boundaries, entity leakage, missing validation), TypeScript and frontend pitfalls (signal and effect…
  • 100spring-boot-java
    Spring Boot (Java) framework guardrails, patterns, and best practices. Use when working with Spring Boot Java projects, or when the user mentions Spring Boot. Provides JPA, Security, REST, WebFlux, and enterprise Java guidelines.
  • 90spring-boot
    Use when modifying a Java application that actually uses Spring Boot, Spring MVC, Spring Security, Spring Data, or Spring-managed configuration.
  • 100spring-boot-expert
    Expert-level Spring Boot, Spring Framework, REST APIs, and microservices development. Use when the user mentions Java, Spring framework, REST APIs, or microservices, or when the task involves Spring Boot Fundamentals.
  • 100code-reviewer
    Use when asked to review, check or diagnose Spring Boot code: a pull request, diff, module or file before it merges; a slow endpoint or query (N+1, unbounded reads, JPA and Hibernate performance); security, JSpecify null-safety, architecture boundaries or Boot 4 migration risks…

Feedback and reports

Your message goes to Bartosz Sokoliński. An email address is needed only for a reply. See the privacy policy.